added optional request params and context limit from GOOSE_PREDEFINED_MODELS#6489
Merged
added optional request params and context limit from GOOSE_PREDEFINED_MODELS#6489
Conversation
jamadeo
force-pushed
the
zane/models-params
branch
from
3b39259 to
83b8224
Compare
jamadeo
approved these changes
Jan 15, 2026
Collaborator
jamadeo
left a comment
jamadeo
left a comment
There was a problem hiding this comment.
Definitely something we need to make possible. But I can't help feeling like doing this with the PREDEFINED_MODELS is a bit of a hack, and means our provider/model config is lacking something.
But maybe we solve that another time.
Collaborator
Author
|
Yeah this is just for internal use currently. Was thinking of following up
with a more robust configuration to allow adding request params with
provider / model setup in the cli and ui. It’s tricky though because
certain providers want it as request parameters and others want them in the
request body.
…On Thu, Jan 15, 2026 at 11:56 AM Jack Amadeo ***@***.***> wrote:
***@***.**** approved this pull request.
Definitely something we need to make possible. But I can't help feeling
like doing this with the PREDEFINED_MODELS is a bit of a hack, and means
our provider/model config is lacking something.
But maybe we solve that another time.
—
Reply to this email directly, view it on GitHub
<#6489 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASBQCEC7HMMJAHNXXNKFAAD4G7WGHAVCNFSM6AAAAACRTJWE5CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNRXGMZDGMBUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
* 'main' of github.com:block/goose: (28 commits) chore(deps): bump aiohttp from 3.13.0 to 3.13.3 in /scripts/provider-error-proxy (#6539) chore(deps): bump brotli from 1.1.0 to 1.2.0 in /scripts/provider-error-proxy (#6538) docs: temp correction for agent directory (#6544) chore: upgrade rmcp (#6516) docs: clarify directory in /documentation readme (#6541) Release 1.20.0 Standalone mcp apps (#6458) don't add escaping to the command field (#6519) Fix popular topics not starting chat when clicked (#6508) fix[desktop]: deeplink ui repeat on refresh (#6469) fixed test compilation on main branch (#6512) fix: correctly parse extension name from tool call for MCP apps (#6482) fixed 0 token in openrouter steaming (#6493) feat(goose-acp): enable parallel sessions with isolated agent state (#6392) copilot instruction to flag prelease docs (#6504) docs: acp mcp support (#6491) feat: add flatpak support for linux (#6387) fix(code_execution): serialize record_result output as JSON (#6495) perf(google): avoid accumulating thoughtSignatures across conversation history (#6462) fix(openai): make tool_call arguments optional and fix silent stream termination (#6309) ...
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 23, 2026
…_MODELS (block#6489) Signed-off-by: fbalicchia <fbalicchia@cuebiq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
added optional request params and context limit from GOOSE_PREDEFINED_MODELS
verified locally does go up to 1M context limit with the following values
displays limit in front end also